adriangb commented on code in PR #17468:
URL: https://github.com/apache/datafusion/pull/17468#discussion_r2330852818
##########
datafusion/common/src/nested_struct.rs:
##########
@@ -215,40 +271,81 @@ mod tests {
};
}
+ fn field(name: &str, data_type: DataType) -> Field {
+ Field::new(name, data_type, true)
+ }
+
+ fn non_null_field(name: &str, data_type: DataType) -> Field {
+ Field::new(name, data_type, false)
+ }
+
+ fn arc_field(name: &str, data_type: DataType) -> FieldRef {
+ Arc::new(field(name, data_type))
+ }
Review Comment:
I don't find these very helpful. The `non_null_field` one maybe because it
tells me in less verbose way what is being created but I'm okay just reading
`Arc::new(...)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
