findepi commented on code in PR #17443: URL: https://github.com/apache/datafusion/pull/17443#discussion_r2330246288
########## docs/source/library-user-guide/upgrading.md: ########## @@ -285,6 +285,24 @@ If you have custom implementations of `FileOpener` or work directly with `FileOp [#17397]: https://github.com/apache/datafusion/pull/17397 +### Added `PhysicalExpr::is_volatile_node` + +We added a method to `PhysicalExpr` to mark a `PhysicalExpr` as volatile: + +```rust,ignore +impl PhysicalExpr for MyRandomExpr { + fn is_volatile_node(&self) -> bool { + true + } +} +``` + +We've shipped this with a default value of `false` to minimize breakage but we highly recommend that implementers of `PhysicalExpr` opt into a behavior, even if it is returning `false`. Review Comment: Do you plan to remove the default implementation? (If not, let's avoid increasing blood pressure in the readers. Let them go without any change for non-volatile expressions.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
