alamb commented on code in PR #2007: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2007#discussion_r2321706757
########## .github/workflows/license.yml: ########## @@ -23,6 +23,7 @@ on: branches: - main pull_request: + merge_group: Review Comment: I reviewed https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#merge_group and this seems right to me ########## .github/workflows/rust.yml: ########## @@ -17,13 +17,17 @@ name: Rust -on: [push, pull_request] +on: + push: + branches-ignore: + - 'gh-readonly-queue/**' Review Comment: What is this for? Can we perhaps add some comments explaining what this branch ignore is for? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org