findepi opened a new pull request, #17441: URL: https://github.com/apache/datafusion/pull/17441
The implementations of `PartialEq` and `PartialOrd` were not consistent violating the `PartialOrd` contract. These traits are used only to use the `ToRepartition`/`RePartition` in a `BinaryHeap`, so it's easy to fix. However, having type-level partial eq (instead of derived) can be fairly misleading. Instead, these are implemented on a newtype pattern, making the semantics clear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
