Jefffrey commented on PR #17378: URL: https://github.com/apache/datafusion/pull/17378#issuecomment-3256506016
> > Would be nice to have a test via DataFrame API if possible. Also for the proto, I think we can raise an issue so we can have it tracked in GitHub. > > Should we also update somewhere in our SQL reference that we now support FILTERS in windows? I notice we don't mention FILTER support for regular aggregates either 🤔 > > Other than that, seems good to me. > > @Jefffrey Thanks for your review! > > I've added [ff0b1c8](https://github.com/apache/datafusion/commit/ff0b1c8d7cb5bb4e80c8b7576f819961daa7ab0d) for the DataFrame API test, and [8ce5de3](https://github.com/apache/datafusion/commit/8ce5de39122fb023f4f2de04253cf7bd1d54c883) for the docs if you want to give it another look. > > Also opened #17417 (Issue is AI generated, but is way clearer than anything I could have written myself!) Looks good 👍 Will merge this later today in case anyone else wants to take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
