ramnes commented on code in PR #2015:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/2015#discussion_r2316395025
##########
src/ast/mod.rs:
##########
@@ -3314,6 +3314,8 @@ pub enum Statement {
CreateRole {
names: Vec<ObjectName>,
if_not_exists: bool,
+ /// Whether ROLE or USER keyword was used
+ keyword: RoleKeyword,
Review Comment:
Again, this would probably need a refactor so that all dialects use the same
structures for `ALTER / CREATE` `USER / ROLE`, but I guess it would make more
sense in a second step – the inconsistency is already there. This PR fixes a
currently broken expression parsing "for free".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
