andygrove commented on code in PR #2242:
URL: https://github.com/apache/datafusion-comet/pull/2242#discussion_r2311638192
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -1875,8 +1875,8 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
+ s"(SELECT c1, cast(make_interval(c0, c1, c0, c1, c0, c0, c2)
as string) as casted from $table) as B "
+ "where A.c1 = B.c1 ",
Set(
- "Comet shuffle is not enabled: spark.comet.exec.shuffle.enabled
is not enabled",
- "make_interval is not supported")),
+ "Cast from CalendarIntervalType to String is not supported",
+ "Comet shuffle is not enabled: spark.comet.exec.shuffle.enabled
is not enabled")),
Review Comment:
This message comes from `CometExecRule`. The message format wasn't modified
as part of this PR, so changing the expected message here seems out of scope
for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
