andygrove commented on code in PR #2251:
URL: https://github.com/apache/datafusion-comet/pull/2251#discussion_r2308038000
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -288,8 +292,25 @@ case class CometScanRule(session: SparkSession) extends
Rule[SparkPlan] with Com
val fallbackReasons = new ListBuffer[String]()
// native_iceberg_compat only supports local filesystem and S3
Review Comment:
No, the only change is that now we have additional checks for the s3 case.
It might not be clear from the diff, but the code changed from:
```
if (!local_filesystem_or_s3) {
// fallback
}
```
to
```
if (local_filesystem_or_s3) {
// additional checks
} else {
// fallback
|
```
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -288,8 +292,25 @@ case class CometScanRule(session: SparkSession) extends
Rule[SparkPlan] with Com
val fallbackReasons = new ListBuffer[String]()
// native_iceberg_compat only supports local filesystem and S3
Review Comment:
No, the only change is that now we have additional checks for the s3 case.
It might not be clear from the diff, but the code changed from:
```
if (!local_filesystem_or_s3) {
// fallback
}
```
to
```
if (local_filesystem_or_s3) {
// additional checks
} else {
// fallback
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
