jonathanc-n commented on code in PR #17300: URL: https://github.com/apache/datafusion/pull/17300#discussion_r2296104212
########## datafusion/physical-plan/src/joins/hash_join/shared_bounds.rs: ########## @@ -0,0 +1,295 @@ +// Licensed to the Apache Software Foundation (ASF) under one Review Comment: Should we call this file `shared_bounds` or `filter_pushdown` as it isn't immediately obvious what `shared_bounds` is for, but I think it is fine. ########## datafusion/physical-plan/src/joins/hash_join/stream.rs: ########## @@ -0,0 +1,624 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Stream implementation for Hash Join Review Comment: We could possibly have something more detailed here to describe: ```suggestion //! Stream implementation for Hash Join //! //! This module implements [`HashJoinStream`], the streaming engine for //! [`HashJoinExec`]. It is responsible for: //! //! - Collecting the build side (left input) into a [`JoinHashMap`] //! - Iterating over the probe side (right input) in streaming fashion //! - Looking up matches against the hash table and applying join filters //! - Producing joined [`RecordBatch`]es incrementally //! - Emitting unmatched rows for outer/semi/anti joins in the final stage ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
