andygrove commented on code in PR #2220:
URL: https://github.com/apache/datafusion-comet/pull/2220#discussion_r2294337903
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -152,15 +152,6 @@ case class CometScanRule(session: SparkSession) extends
Rule[SparkPlan] {
return withInfos(scanExec, fallbackReasons.toSet)
}
- if (scanImpl == CometConf.SCAN_NATIVE_DATAFUSION &&
(SQLConf.get.ignoreMissingFiles ||
Review Comment:
This block is checking `ignoreMissingFiles`, and the previous block is
checking `ignoreCorruptFiles`. The code blocks are similar, but serve different
purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
