comphead commented on code in PR #2213:
URL: https://github.com/apache/datafusion-comet/pull/2213#discussion_r2294332342


##########
spark/src/main/scala/org/apache/comet/serde/hash.scala:
##########
@@ -75,7 +75,7 @@ object CometSha2 extends CometExpressionSerde[Sha2] {
     // It's possible for spark to dynamically compute the number of bits from 
input
     // expression, however DataFusion does not support that yet.
     if (!expr.right.foldable) {
-      withInfo(expr, "For Sha2, non-foldable right argument is not supported")
+      withInfo(expr, "For Sha2, non literal numBits is not supported")

Review Comment:
   I think its called `bitLength` 
https://spark.apache.org/docs/latest/api/sql/#sha2



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to