Omega359 commented on code in PR #10:
URL: https://github.com/apache/datafusion-testing/pull/10#discussion_r2273463811


##########
data/sqlite/random/expr/slt_good_79.slt:
##########
@@ -42352,10 +42361,16 @@ SELECT ALL 34 * - 82 / - ( - - 41 ) AS col0
 ----
 68
 
-# Datafusion - Datafusion expected results:
-# Datafusion - Expected - 0
-query error DataFusion error: Execution error: avg\(DISTINCT\) aggregations 
are not available
+# Datafusion - Data was automatically updated based on comparison db results
+# Datafusion - Previous results:
+# Datafusion - 0
+# Datafusion - Types were automatically converted from:
+# Datafusion - [Expected] [I]
+# Datafusion - [Actual  ] [R]
+query R rowsort label-8087
 SELECT + - 56 / - COALESCE ( 66, + 49 * - ( - AVG ( DISTINCT - NULLIF ( - - 
92, 91 + - - CAST ( + 60 AS INTEGER ) ) ) ) + CAST ( NULL AS INTEGER ) ) AS col0
+----
+0.848484848485

Review Comment:
   Anytime you see '# Datafusion - Data was automatically updated based on 
comparison db results' it means that the results didn't match sqlite but did 
match postgresql (the comparison db) and since I trust postgres to have better 
results than sqlite if df matches postgres it's just explicitly updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to