alamb commented on code in PR #17115:
URL: https://github.com/apache/datafusion/pull/17115#discussion_r2267100928
##########
datafusion/physical-plan/src/sorts/merge.rs:
##########
@@ -49,7 +49,8 @@ pub(crate) struct SortPreservingMergeStream<C: CursorValues> {
/// used to record execution metrics
metrics: BaselineMetrics,
- /// If the stream has encountered an error
+ /// If the stream has encountered an error or reaches the
Review Comment:
I double checked and this is accurate
https://github.com/apache/datafusion/blob/0185da6f60f90dd0d3c3f6732233b58667706230/datafusion/physical-plan/src/sorts/merge.rs#L284-L283
Though given that perhaps we should rename the flag to something like `done`
to be less misleading 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
