mbutrovich commented on code in PR #2075: URL: https://github.com/apache/datafusion-comet/pull/2075#discussion_r2261157508
########## spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala: ########## @@ -1679,6 +1660,30 @@ object QueryPlanSerde extends Logging with CometExprShim { withInfo(expr, s"${expr.prettyName} is not supported", expr.children: _*) None } + }) + } + + def stringDecode( Review Comment: @andygrove Is there somewhere outside of QueryPlanSerde that makes more sense for this, as you've recently been refactoring serde logic? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org