findepi commented on code in PR #17070:
URL: https://github.com/apache/datafusion/pull/17070#discussion_r2260475339
##########
datafusion/core/src/lib.rs:
##########
@@ -744,8 +744,16 @@ pub mod physical_planner;
pub mod prelude;
pub mod scalar;
-// re-export dependencies from arrow-rs to minimize version maintenance for
crate users
+// re-export dependencies to minimize version maintenance for crate users
pub use arrow;
+/// Re-export of the [`object_store`] crate so users can access object store
+/// types without depending on `object_store` directly.
Review Comment:
I think rationale for exporting arrow, parquet is similar to the one for
object store.
We can make all similar & short
```
// Re-export dependencies that are part of DataFusion public API (e.g. via
DataFusionError)
```
No need for code example. It doesn't help understand the _why_.
##########
datafusion/common/src/lib.rs:
##########
@@ -83,6 +83,9 @@ pub use functional_dependencies::{
use hashbrown::hash_map::DefaultHashBuilder;
pub use join_type::{JoinConstraint, JoinSide, JoinType};
pub use null_equality::NullEquality;
+#[cfg(feature = "object_store")]
+/// Reexport object_store crate
+pub use object_store;
Review Comment:
it's exported publicly elsewhere as `datafusion::object_store`
let's not export it from the common crate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
