findepi commented on code in PR #16625:
URL: https://github.com/apache/datafusion/pull/16625#discussion_r2259700775


##########
datafusion/functions-aggregate/src/array_agg.rs:
##########
@@ -78,12 +81,14 @@ This aggregation function can only mix DISTINCT and ORDER 
BY if the ordering exp
 /// ARRAY_AGG aggregate expression
 pub struct ArrayAgg {
     signature: Signature,
+    is_input_pre_ordered: bool,

Review Comment:
   Adding this new field should trigger adding equals/hash_value 
implementations.
   Being fixed in https://github.com/apache/datafusion/pull/17065



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to