jonathanc-n commented on code in PR #17062: URL: https://github.com/apache/datafusion/pull/17062#discussion_r2259644955
########## datafusion/core/tests/parquet/page_pruning.rs: ########## @@ -903,8 +903,8 @@ async fn without_pushdown_filter() { ) .unwrap(); - // Without filter will not read pageIndex. - assert!(bytes_scanned_with_filter > bytes_scanned_without_filter); + // Same amount of bytes are scanned when defaulting to cache parquet metadata Review Comment: @nuno-faria this change seems to be brought by `CachedParquetFileReaderFactory` you added. I just changed the test to reflect the correct behaviour after using the factory as the default now. Just making sure if it looks correct? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org