kazuyukitanimura commented on issue #477: URL: https://github.com/apache/datafusion-comet/issues/477#issuecomment-3140788382
Thanks @kination In the unhex test https://github.com/apache/datafusion-comet/blob/main/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala#L1433 We only have limited test cases. You can use `makeParquetFileAllPrimitiveTypes` to create test dictionary values and some random values The test case with dictionary may fail because I do not see dictionary handling at https://github.com/apache/datafusion-comet/blob/main/native/spark-expr/src/math_funcs/unhex.rs#L67 It is possible the tests with dictionary still passes if we are unpacking in advance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
