andygrove commented on code in PR #2030: URL: https://github.com/apache/datafusion-comet/pull/2030#discussion_r2237927682
########## spark/src/main/scala/org/apache/comet/serde/arrays.scala: ########## @@ -136,7 +136,7 @@ object CometArrayAppend extends CometExpressionSerde with IncompatExpr { } } -object CometArrayContains extends CometExpressionSerde with IncompatExpr { +object CometArrayContains extends CometExpressionSerde { Review Comment: Thanks. I plan on reviewing this PR tomorrow. I would just want to be sure that we have adequate testing of edge cases now that we are removing `IncompatExpr`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org