adriangb commented on PR #16789: URL: https://github.com/apache/datafusion/pull/16789#issuecomment-3084383240
> Are we worried about memory overhead with this? One thing I think we could do is set a reasonable limit to the cache size - only write to the cache if `size` is less than 1024 * 1024 items (so limit memory usage to a couple MB). The default batch size is 16k so this should be more than enough to cache batch size items while ensuring that any calls for arrays of 100M items don't leak multiple MBs of memory. I've implemented a max number of items of 1M. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
