iffyio commented on code in PR #1945:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1945#discussion_r2212639205
##########
src/ast/mod.rs:
##########
@@ -7641,13 +7641,32 @@ impl fmt::Display for DuplicateTreatment {
}
}
+#[derive(Debug, Copy, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
+#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
+#[cfg_attr(feature = "visitor", derive(Visit, VisitMut))]
+pub enum AnalyzeFormatKind {
+ Keyword(AnalyzeFormat),
+ Assignment(AnalyzeFormat),
+}
Review Comment:
Could we add some description ideally with example syntax to show the
difference between each variant? Thinking that might not be obvious otherwise
to someone looking at the API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
