yoavcloud commented on code in PR #1941:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1941#discussion_r2209218297
##########
src/dialect/snowflake.rs:
##########
@@ -365,6 +364,18 @@ impl Dialect for SnowflakeDialect {
false
}
+ // `LIMIT` can be considered an alias as long as it's not followed
by a value. For example:
+ // `SELECT * FROM tbl LIMIT WHERE 1=1` - alias
+ // `SELECT * FROM tbl LIMIT 3` - not an alias
+ Keyword::LIMIT
+ if matches!(
+ parser.peek_token().token,
+ Token::Number(_, _) | Token::Placeholder(_)
Review Comment:
Thanks for the great feedback! The latest commit introduces a more accurate
lookahead logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
