alamb commented on code in PR #16649:
URL: https://github.com/apache/datafusion/pull/16649#discussion_r2202528175
##########
datafusion/datasource-parquet/src/file_format.rs:
##########
@@ -959,14 +953,18 @@ pub async fn fetch_parquet_metadata(
store: &dyn ObjectStore,
meta: &ObjectMeta,
size_hint: Option<usize>,
- decryption_properties: Option<&FileDecryptionProperties>,
+ #[allow(unused)] decryption_properties: Option<&FileDecryptionProperties>,
Review Comment:
A nicer API over the long term would be to move the arguments of
`fetch_parquet_metadata` to a struct, and then have a field in that struct be
different if the feature was enabled.
That could also be a different / follow on PR if we wanted to pursue it
##########
datafusion/core/Cargo.toml:
##########
@@ -61,13 +61,21 @@ default = [
"unicode_expressions",
"compression",
"parquet",
+ "parquet_encryption",
Review Comment:
I would personally prefer if it was not part of the default features but
given it is already on by default on main, I think it is fine to leave it on by
default in this PR
We can discuss disabling the feature by default as a follow on ticket / PR
perhaps
Here are some notes I wrote about how to make it a non default feature:
1. Don't add it to the default features
1. Update the docs to mention the config setting requires the
`parquet_encryption` feature --
https://github.com/apache/datafusion/blob/d66d6b9eb83a4643bc8d1ee9c2da7f0fa644c0cf/datafusion/common/src/config.rs#L1839
2. Enable it in datafusion-cli (add `parquet_encryption` in
https://github.com/apache/datafusion/blob/ca16255e725bf6676a8ddd4b9948496d99b5bd88/datafusion-cli/Cargo.toml#L45-L44)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
