iffyio commented on code in PR #1933:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1933#discussion_r2200438892
##########
tests/sqlparser_common.rs:
##########
@@ -15895,3 +15895,11 @@ fn parse_create_procedure_with_parameter_modes() {
_ => unreachable!(),
}
}
+
+ #[test]
+ fn test_unicode_support() {
Review Comment:
```suggestion
fn test_identifier_unicode_support() {
```
##########
tests/sqlparser_common.rs:
##########
@@ -15895,3 +15895,11 @@ fn parse_create_procedure_with_parameter_modes() {
_ => unreachable!(),
}
}
+
+ #[test]
+ fn test_unicode_support() {
+ let unicode_sql = r#"SELECT phoneǤЖשचᎯ⻩☯♜🦄⚛🀄ᚠ⌛🌀 tbl FROM customers"#;
+ let dialects_supporting_unicode =
TestedDialects::new(vec![Box::new(MySqlDialect {}), Box::new(RedshiftSqlDialect
{}), Box::new(PostgreSqlDialect {})]);
+ let _ =
dialects_supporting_unicode.parse_sql_statements(unicode_sql).unwrap();
Review Comment:
```suggestion
let sql = r#"SELECT phoneǤЖשचᎯ⻩☯♜🦄⚛🀄ᚠ⌛🌀 tbl FROM customers"#;
let dialects = TestedDialects::new(vec![Box::new(MySqlDialect {}),
Box::new(RedshiftSqlDialect {}), Box::new(PostgreSqlDialect {})]);
let _ = dialects.verified_stmt(unicode_sql);
```
##########
src/dialect/mysql.rs:
##########
@@ -51,7 +51,7 @@ impl Dialect for MySqlDialect {
}
fn is_identifier_part(&self, ch: char) -> bool {
- self.is_identifier_start(ch) || ch.is_ascii_digit()
+ self.is_identifier_start(ch) || ch.is_ascii_digit() || !ch.is_ascii()
Review Comment:
Can we add a comment to these highlighting that they implement unicode
character support?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
