Copilot commented on code in PR #2011:
URL: https://github.com/apache/datafusion-comet/pull/2011#discussion_r2198329182
##########
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala:
##########
@@ -56,6 +56,7 @@ import org.apache.comet.objectstore.NativeConfig
import org.apache.comet.serde.ExprOuterClass.{AggExpr, DataType =>
ProtoDataType, Expr, ScalarFunc}
import org.apache.comet.serde.ExprOuterClass.DataType._
import org.apache.comet.serde.OperatorOuterClass.{AggregateMode =>
CometAggregateMode, BuildSide, JoinType, Operator}
+import org.apache.comet.serde.QueryPlanSerde.{exprToProtoInternal,
optExprWithInfo, scalarFunctionExprToProto}
Review Comment:
[nitpick] Importing members of `QueryPlanSerde` within its own file can be
confusing and risks circularity; consider moving `UnaryScalarFuncSerde` inside
the `QueryPlanSerde` object or referencing the methods via the object name
instead of a self-import.
```suggestion
// Removed self-import to avoid circularity and improve clarity.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
