jonathanc-n commented on code in PR #16716:
URL: https://github.com/apache/datafusion/pull/16716#discussion_r2196274758


##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -1498,6 +1498,23 @@ impl HashJoinStream {
 
         let timer = self.join_metrics.join_time.timer();
 
+        // if the left side is empty, we can skip the (potentially expensive) 
join operation

Review Comment:
   I think we can do this in a follow up pr wdyt @nuno-faria?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to