kazuyukitanimura commented on code in PR #2000:
URL: https://github.com/apache/datafusion-comet/pull/2000#discussion_r2196260122
##########
common/src/main/java/org/apache/comet/parquet/ParquetColumnSpec.java:
##########
@@ -19,28 +19,45 @@
package org.apache.comet.parquet;
+import java.util.Map;
+
public class ParquetColumnSpec {
+ private final int fieldId;
private final String[] path;
private final String physicalType;
private final int typeLength;
private final boolean isRepeated;
private final int maxDefinitionLevel;
private final int maxRepetitionLevel;
+ // Logical type info
+ private String logicalTypeName;
+ private Map<String, String> logicalTypeParams;
+
public ParquetColumnSpec(
+ int fieldId,
String[] path,
String physicalType,
int typeLength,
boolean isRepeated,
int maxDefinitionLevel,
- int maxRepetitionLevel) {
+ int maxRepetitionLevel,
+ String logicalTypeName,
Review Comment:
Wondering if we can directly pass `LogicalTypeAnnotation` rather than
passing a `String` and reconstructing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
