alamb opened a new issue, #16729: URL: https://github.com/apache/datafusion/issues/16729
### Is your feature request related to a problem or challenge? In order to enable `filter_pushdown` by default, we need to ensure it doesn't regress existing performance However, it has been very hard to make forward progress on improving filter pushdown because all our benchmarks compare filter pushdown to not filter pushdown, so the bar for change is quite high. Here is the most recent example: - https://github.com/apache/datafusion/pull/16711 ### Describe the solution you'd like I would like a benchmark to measure for improvements to the filter pushdown are comparing when filter pushdown is already on. However, we don't have any such benchmark There is one existing benchmark called `parquet` but it seems not to capture real world filter pushdown usecases and is not often run (I have never seen or heard of anyone running it) ### Describe alternatives you've considered 1. Remove the old `"parquet"` benchmark (that isn't used) 2. Add a new `clickbench_filter_pushdown` benchmark that runs the same clickbench queries with filter pushdown enabled ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
