Dandandan commented on code in PR #16727:
URL: https://github.com/apache/datafusion/pull/16727#discussion_r2195662267
##########
datafusion/physical-plan/src/joins/hash_join.rs:
##########
@@ -1005,46 +1016,46 @@ async fn collect_left_input(
let mut offset = 0;
// Updating hashmap starting from the last batch
- let batches_iter = batches.iter().rev();
- for batch in batches_iter.clone() {
- hashes_buffer.clear();
- hashes_buffer.resize(batch.num_rows(), 0);
- update_hash(
- &on_left,
- batch,
- &mut *hashmap,
- offset,
- &random_state,
- &mut hashes_buffer,
- 0,
- true,
- )?;
- offset += batch.num_rows();
+
+ let batches_iter = batches.iter();
+ let mut coalescer = BatchCoalescer::new(schema, num_rows);
Review Comment:
I think `BatchCoalescer` has no benefit here as it will currently
concatenate to a single batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
