ding-young opened a new issue, #16712:
URL: https://github.com/apache/datafusion/issues/16712
### Background
Rust 1.86 stabilized [f64::{next_up,
next_down}](https://doc.rust-lang.org/std/primitive.f64.html#method.next_up)
and [f32::{next_down,
next_up}](https://doc.rust-lang.org/std/primitive.f32.html#method.next_up), so
we can now replace several hardcoded floating-point constants using these
methods. Replacing manually defined constants with std library can improve
clarity and correctness.
See several functions starting from
https://github.com/apache/datafusion/blob/a089eff251f13ac52ba070dbdf67cc20d7851662/datafusion/common/src/scalar/mod.rs#L1191-L1202
and
https://github.com/apache/datafusion/blob/main/datafusion/common/src/scalar/consts.rs
### Solution
1. Update related functions in `datafusion/common/src/scalar/mod.rs`
2. Verify that the updated values match the current constants, or document
any small differences that arise due to precision changes.
I think this is a good first issue :)
The TODO comment is originally added in
https://github.com/apache/datafusion/pull/11584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
