drexler-sky commented on code in PR #1992:
URL: https://github.com/apache/datafusion-comet/pull/1992#discussion_r2191617409


##########
native/core/src/parquet/parquet_support.rs:
##########
@@ -384,6 +392,17 @@ pub(crate) fn prepare_object_store_with_configs(
 
     let (object_store, object_store_path): (Box<dyn ObjectStore>, Path) = if 
scheme == "hdfs" {
         parse_hdfs_url(&url)
+    } else if scheme == "s3" && use_jni {

Review Comment:
   Thanks! I updated the code to scan for `spark.hadoop.fs.<scheme>.impl` 
configs and use `JniObjectStore` for any matching scheme when `use_jni` is 
true. 



##########
native/core/src/parquet/objectstore/jni.rs:
##########
@@ -0,0 +1,332 @@
+// Licensed to the Apache Software Foundation (ASF) under one

Review Comment:
   Changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to