ding-young commented on PR #16706: URL: https://github.com/apache/datafusion/pull/16706#issuecomment-3047193295
> Thanks @ding-young looks good can this PR also have a bench file or benchmark run results to understand the optimization in numbers? Thank you @comphead When I run `cargo bench --bench to_array_size_of` with criterion bench script (in https://github.com/apache/datafusion/compare/main...ding-young:datafusion:scalar-struct-test), perf has improved compared to main branch. I didn't add the bench script in this PR because I think we won't run this bench again after it gets merged.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
