alamb commented on code in PR #16705:
URL: https://github.com/apache/datafusion/pull/16705#discussion_r2190383456


##########
datafusion/expr/src/logical_plan/dml.rs:
##########
@@ -89,6 +91,26 @@ impl Hash for CopyTo {
     }
 }
 
+impl CopyTo {
+    pub fn new(
+        input: Arc<LogicalPlan>,
+        output_url: String,
+        partition_by: Vec<String>,
+        file_type: Arc<dyn FileType>,
+        options: HashMap<String, String>,
+    ) -> Self {
+        Self {
+            input,
+            output_url,
+            partition_by,
+            file_type,
+            options,
+            // The output schema is always a single column with the number of 
rows copied

Review Comment:
   ```suggestion
               // The output schema is always a single column "count" with the 
number of rows copied
   ```



##########
datafusion/expr/src/logical_plan/dml.rs:
##########
@@ -40,6 +40,7 @@ pub struct CopyTo {
     pub file_type: Arc<dyn FileType>,
     /// SQL Options that can affect the formats
     pub options: HashMap<String, String>,
+    pub output_schema: DFSchemaRef,

Review Comment:
   ```suggestion
       /// The schema of the output (a single column "count")
       pub output_schema: DFSchemaRef,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to