2010YOUY01 commented on code in PR #16674:
URL: https://github.com/apache/datafusion/pull/16674#discussion_r2184635238
##########
datafusion/physical-plan/src/joins/symmetric_hash_join.rs:
##########
@@ -1375,7 +1375,7 @@ impl<T: BatchTransformer> SymmetricHashJoinStream<T> {
}
Some((batch, _)) => {
self.metrics.output_batches.add(1);
- self.metrics.output_rows.add(batch.num_rows());
+ self.metrics.baseline_metrics.output_rows();
Review Comment:
To keep the implementation consistent with the majority of operators, I
suggest to use the following API to track output rows:
https://github.com/apache/datafusion/blob/25c2a079fc1baacc038e304cb2bcae671338c2d8/datafusion/physical-plan/src/metrics/baseline.rs#L124
This API should be used when the final output is ready to output to the
downstream operator, and it can also automatically update some other
`BaselineMetrics`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
