iffyio commented on code in PR #1921:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1921#discussion_r2183258157
##########
tests/sqlparser_common.rs:
##########
@@ -11125,16 +11125,9 @@ fn parse_trailing_comma() {
);
trailing_commas.verified_stmt(r#"SELECT "from" FROM "from""#);
- // doesn't allow any trailing commas
+ // doesn't allow all trailing commas
let trailing_commas = TestedDialects::new(vec![Box::new(GenericDialect
{})]);
- assert_eq!(
Review Comment:
could we instead change this to use a dialect like postgres that doesnt
support trailing commas? thinking that would let us keep the negative test
around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
