adriangb commented on code in PR #16642:
URL: https://github.com/apache/datafusion/pull/16642#discussion_r2182671663
##########
datafusion/physical-plan/src/filter_pushdown.rs:
##########
@@ -291,18 +136,8 @@ impl<T> FilterPushdownPropagation<T> {
}
}
- /// Create a new [`FilterPushdownPropagation`] that tells the parent node
- /// that none of the parent filters were not pushed down.
- pub fn unsupported(parent_filters: Vec<Arc<dyn PhysicalExpr>>) -> Self {
- let unsupported = PredicateSupports::all_unsupported(parent_filters);
- Self {
- filters: unsupported,
- updated_node: None,
- }
- }
-
/// Create a new [`FilterPushdownPropagation`] with the specified filter
support.
- pub fn with_filters(filters: PredicateSupports) -> Self {
+ pub fn with_filters(filters: Vec<PredicateSupport>) -> Self {
Review Comment:
On the balance we had way too many methods before. I think I'd rather go
with less methods for now and then we can have focused PRs in the future to add
helper methods where it makes sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
