crepererum commented on code in PR #16615:
URL: https://github.com/apache/datafusion/pull/16615#discussion_r2182268817
##########
datafusion/expr/src/expr_fn.rs:
##########
@@ -821,7 +821,7 @@ impl ExprFuncBuilder {
let fun_expr = match fun {
ExprFuncKind::Aggregate(mut udaf) => {
- udaf.params.order_by = order_by;
+ udaf.params.order_by = order_by.unwrap_or_default();
Review Comment:
since this type is private and the builder `fn order_by` already takes a
`Vec` w/o an `Option`, could we just do this in this PR as well? It's like a
2-line change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
