gabotechs commented on code in PR #16662:
URL: https://github.com/apache/datafusion/pull/16662#discussion_r2181971781


##########
datafusion/proto/tests/cases/roundtrip_physical_plan.rs:
##########
@@ -1736,3 +1737,57 @@ async fn roundtrip_physical_plan_node() {
 
     let _ = plan.execute(0, ctx.task_ctx()).unwrap();
 }
+
+#[tokio::test]
+async fn test_tpch_part_in_list_query_with_real_parquet_data() -> Result<()> {
+    // Test the specific query: SELECT p_size FROM part WHERE p_size IN (14, 
6, 5, 31)
+    // This uses REAL TPC-H parquet data to reproduce the serialization bug 
with actual data sources
+    //
+    // NOTE: This test requires TPC-H data to reproduce the serialization bug.
+    // Using alltypes_plain.parquet does NOT reproduce the issue, suggesting 
the bug
+    // is specific to certain characteristics of TPC-H parquet files or their 
schema.
+
+    // Check if TPC-H data is available
+    if !Path::new("/tmp/tpch_s1/part.parquet").exists() {

Review Comment:
   Does the CI dump tpch data in `/tmp`? if it does not this test might never 
be enforced in any pipeline. I see there's a `testdata` folder near these 
tests, maybe we can dump a truncated version of the parquet file there?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to