kosiew commented on code in PR #16589:
URL: https://github.com/apache/datafusion/pull/16589#discussion_r2181554365
##########
datafusion/physical-expr-adapter/src/schema_rewriter.rs:
##########
@@ -234,233 +333,141 @@ mod tests {
let result = rewriter.rewrite(column_expr).unwrap();
- // Should be wrapped in a cast expression
- assert!(result.as_any().downcast_ref::<CastExpr>().is_some());
- }
-
- #[test]
- fn test_rewrite_mulit_column_expr_with_type_cast() {
Review Comment:
Is there a reason for replacing this multi column test with the single
column test_rewrite_column_with_type_cast?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
