UBarney commented on code in PR #16443:
URL: https://github.com/apache/datafusion/pull/16443#discussion_r2177790602
##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -1215,16 +1324,25 @@ pub(crate) mod tests {
batches.extend(
more_batches
.into_iter()
+ .inspect(|b| {
+ assert!(b.num_rows() <=
context.session_config().batch_size())
+ })
.filter(|b| b.num_rows() > 0)
.collect::<Vec<_>>(),
);
}
Ok((columns, batches))
}
+ fn new_task_ctx() -> Arc<TaskContext> {
+ let base = TaskContext::default();
+ // limit max size of intermediate batch used in nlj to 1
+ let cfg = base.session_config().clone().with_batch_size(1);
Review Comment:
DONE
##########
datafusion/physical-plan/src/joins/nested_loop_join.rs:
##########
@@ -729,10 +716,26 @@ struct NestedLoopJoinStream<T> {
right_side_ordered: bool,
/// Current state of the stream
state: NestedLoopJoinStreamState,
+ #[allow(dead_code)]
+ // TODO: remove this field ??
Review Comment:
DONE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
