findepi commented on PR #16628: URL: https://github.com/apache/datafusion/pull/16628#issuecomment-3022345087
> To be clear the cleanup is to rearrange the functions in alphabetical order, right? In the `Collocate name and aliases in code` commit the idea is to put `aliases()` just after `name()`. as they are tightly related, it makes sense to have them next to each other. When implementing a trait, IDE will often generate function stubs in the same order as in the trait declaration, so having related methods grouped together helps implementors write better code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
