findepi opened a new pull request, #16625:
URL: https://github.com/apache/datafusion/pull/16625

   ## Which issue does this PR close?
   
   None. https://github.com/apache/datafusion/issues/8582 is related.
   
   ## Rationale for this change
   
   Before the change, `array_agg` with ordering would depend on input being
   ordered. As a result, it was impossible to do two or more `array_agg(x
   ORDER BY ...)` with incompatible ordering. 
   
   ## What changes are included in this PR?
   
   This change moves ordering
   responsibility into `OrderSensitiveArrayAggAccumulator`. When input is
   pre-ordered (beneficial ordering), no additional work is done. However,
   when it's not, `array_agg` accumulator will order the data on its own.
   
   ## Are these changes tested?
   
   Yes
   
   ## Are there any user-facing changes?
   
   Yes
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to