hsiang-c commented on code in PR #1920:
URL: https://github.com/apache/datafusion-comet/pull/1920#discussion_r2167782872
##########
common/src/main/java/org/apache/comet/parquet/FileReader.java:
##########
@@ -128,6 +134,48 @@ public FileReader(InputFile file, ParquetReadOptions
options, ReadOptions cometO
this(file, null, options, cometOptions, null);
}
+ /** This constructor is called from Apache Iceberg. */
+ public FileReader(
+ Path path,
+ Configuration conf,
+ ReadOptions cometOptions,
+ Map<String, String> properties,
+ Long start,
+ Long length,
+ byte[] fileEncryptionKey,
+ byte[] fileAADPrefix)
+ throws IOException {
+ ParquetReadOptions options =
+ buildParquetReadOptions(conf, properties, start, length,
fileEncryptionKey, fileAADPrefix);
+ this.converter = new ParquetMetadataConverter(options);
+ this.file = HadoopInputFile.fromPath(path, conf);
Review Comment:
Can we use `CometInputFile` here? According to the doc
```java
/**
* A Parquet {@link InputFile} implementation that's similar to {@link
* org.apache.parquet.hadoop.util.HadoopInputFile}, but with optimizations
introduced in Hadoop 3.x,
* for S3 specifically.
*/
public class CometInputFile implements InputFile {
// omitted
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
