Fly-Style commented on PR #16483:
URL: https://github.com/apache/datafusion/pull/16483#issuecomment-2999735349
Benchmark results:
```
Benchmarking compute_hex_new: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase
target time to 5.1s, or reduce sample count to 90.
compute_hex_new time: [49.225 ms 49.905 ms 50.779 ms]
Found 8 outliers among 100 measurements (8.00%)
2 (2.00%) high mild
6 (6.00%) high severe
Benchmarking compute_hex_old: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase
target time to 5.0s, or reduce sample count to 90.
compute_hex_old time: [50.322 ms 50.565 ms 50.820 ms]
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild
```
Benchmark code:
<details>
```
use arrow::array::PrimitiveDictionaryBuilder;
use arrow::datatypes::{Int32Type, Int64Type};
use criterion::{criterion_group, criterion_main, Criterion};
use datafusion_expr::ColumnarValue;
use datafusion_spark::function::math::hex::{compute_hex, compute_hex_old};
use std::sync::Arc;
const DICT_SIZE: i64 = 1024 * 1024;
fn criterion_benchmark(c: &mut Criterion) {
let mut input_builder = PrimitiveDictionaryBuilder::<Int32Type,
Int64Type>::new();
for i in 0..DICT_SIZE {
input_builder.append_value((DICT_SIZE - i) * 1024);
}
let input = input_builder.finish();
let columnar_value = ColumnarValue::Array(Arc::new(input));
c.bench_function("compute_hex_new", |b| {
b.iter(|| compute_hex(&[columnar_value.clone()], false).unwrap());
});
c.bench_function("compute_hex_old", |b| {
b.iter(|| compute_hex_old(&[columnar_value.clone()],
false).unwrap());
});
}
criterion_group!(benches, criterion_benchmark);
criterion_main!(benches);
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
