timsaucer commented on code in PR #1169:
URL:
https://github.com/apache/datafusion-python/pull/1169#discussion_r2165031025
##########
python/datafusion/dataframe.py:
##########
@@ -873,7 +877,7 @@ def write_csv(self, path: str | pathlib.Path, with_header:
bool = False) -> None
def write_parquet(
self,
path: str | pathlib.Path,
- compression: Union[str, Compression] = Compression.ZSTD,
+ compression: Union[str, Compression, ParquetWriterOptions] =
Compression.ZSTD,
compression_level: int | None = None,
) -> None:
"""Execute the :py:class:`DataFrame` and write the results to a
Parquet file.
Review Comment:
This change is nice. I think it would be a little better for type hinting in
IDEs if we overload the method signatures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
