2010YOUY01 commented on code in PR #16497:
URL: https://github.com/apache/datafusion/pull/16497#discussion_r2163184021
##########
datafusion/physical-plan/src/unnest.rs:
##########
@@ -284,7 +279,9 @@ impl UnnestStream {
loop {
return Poll::Ready(match ready!(self.input.poll_next_unpin(cx)) {
Some(Ok(batch)) => {
- let timer = self.metrics.elapsed_compute.timer();
+ let elapsed_compute =
+
self.metrics.baseline_metrics.elapsed_compute().clone();
+ let timer = elapsed_compute.timer();
Review Comment:
```suggestion
let _timer = elapsed_compute.timer(); // starts timer;
stops on drop
```
~~nit: for readability~~ Never mind, I didn't notice the later `.done()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
