xudong963 commented on code in PR #16445: URL: https://github.com/apache/datafusion/pull/16445#discussion_r2162984236
########## datafusion/core/tests/physical_optimizer/filter_pushdown/mod.rs: ########## @@ -433,6 +433,117 @@ async fn test_topk_dynamic_filter_pushdown() { ); } +#[tokio::test] +async fn test_hashjoin_dynamic_filter_pushdown() { Review Comment: Such test can check 1. dynamic filters are pushed down to right scan node 2. dynamic filters aren't missed during pushdown -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org