leung-ming commented on code in PR #1914:
URL: https://github.com/apache/datafusion-comet/pull/1914#discussion_r2163222203
##########
native/spark-expr/src/conversion_funcs/cast.rs:
##########
@@ -1298,6 +1298,7 @@ where
});
} else {
cast_array.append_null();
+ continue;
Review Comment:
> I am surprised that no existing tests caught this issue 😕. As
@parthchandra said, it would be good to have a test in `CometCastSuite` to
expose this bug.
Maybe hidden by #1372? I found this issue when I testing #1915 (which marked
the cast as compatible) with existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
