iffyio commented on code in PR #1896:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1896#discussion_r2163073711
##########
src/test_utils.rs:
##########
@@ -366,6 +366,11 @@ pub fn number(n: &str) -> Value {
Value::Number(n.parse().unwrap(), false)
}
+/// Creates a `Value::SingleQuotedString`
+pub fn single_quoted_string(s: &str) -> Value {
+ Value::SingleQuotedString(s.to_string())
+}
Review Comment:
```suggestion
/// Creates a [Value::SingleQuotedString]
pub fn single_quoted_string(s: impl Into<String>) -> Value {
Value::SingleQuotedString(s.into())
}
```
Thinking we can make this accept the various string types?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
