aditanase commented on code in PR #16049:
URL: https://github.com/apache/datafusion/pull/16049#discussion_r2162023768
##########
datafusion/optimizer/src/push_down_filter.rs:
##########
@@ -4123,4 +4127,34 @@ mod tests {
"
)
}
+
+ /// Create a test table scan with uppercase column names for case
sensitivity testing
+ fn test_table_scan_with_uppercase_columns() -> Result<LogicalPlan> {
+ let schema = Schema::new(vec![
+ Field::new("A", DataType::UInt32, false),
+ Field::new("B", DataType::UInt32, false),
+ Field::new("C", DataType::UInt32, false),
+ ]);
+ table_scan(Some("test"), &schema, None)?.build()
+ }
+
+ #[test]
+ fn filter_agg_case_insensitive() -> Result<()> {
+ let table_scan = test_table_scan_with_uppercase_columns()?;
Review Comment:
Great question, just tried this and it works as expected for both uppercase
and lower case col, even if both are present in the schema at the same time. I
added another test, lmk if we should keep it or it's overkill.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
